Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): fix disabled button style in PD #16445

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix(components): fix disabled button style in PD #16445

merged 1 commit into from
Oct 11, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Oct 9, 2024

Overview

modify the disabled button style for PD and fix block issue in LargeButton.

before

Screenshot 2024-10-09 at 12 19 39 PM

after

Screenshot 2024-10-09 at 12 59 27 PM

close RQA-3278

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

modify the disabled button style for PD and fix block issue in LargeButton
@koji koji requested review from ncdiehl11 and jerader October 9, 2024 17:14
@koji koji marked this pull request as ready for review October 9, 2024 17:14
@koji koji requested review from a team as code owners October 9, 2024 17:14
@koji koji added the authorship label Oct 9, 2024
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this and should've checked that the border was a bug 😓 Thanks for fixing

@koji koji merged commit 7e42388 into edge Oct 11, 2024
58 checks passed
@koji koji deleted the fix_RQA-3278 branch October 11, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants