-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app,api): Display thermocycler profile cycles #16414
Commits on Oct 4, 2024
-
feat(api): add tc extended profiles to hcapi
These extended profiles match the way that you can configure a thermocycler in protocol designer. They support a mix of cycles (more than one per profile) and out-of-cycle steps, while keeping structure down to hardware. That last part is sadly important to support currently-exposed details up from the hardware controller.
Configuration menu - View commit details
-
Copy full SHA for 95dd07d - Browse repository at this point
Copy the full SHA 95dd07dView commit details -
feat(api,shared-data): add runExtendedProfile
This is a thermocycler command that accepts a structured sequence of temperatures and wait times instead of a flat list. A profile is a list of either steps or cycles; cycles are a repetition count plus a list of steps. The actual _functionality_ of the command is exactly the same as thermocycler/runProfile; the only change is pushing down the structure of the information, which is currently lost when creating a runProfile command and thus unavailable to protocol clients for display.
Configuration menu - View commit details
-
Copy full SHA for f0eec27 - Browse repository at this point
Copy the full SHA f0eec27View commit details -
fix(app): update thermocycler command text
This PR does a couple things with thermocycler command text. First, it changes the phrasing of the thermocycler/runProfile command text to make it more clear that no cycles are involved: it's just a big list of steps. Second, it adds a command text for the new thermocycler/runExtendedProfile command, which does have the structured data necessary to render things as cycles. This unfortunately makes it a multilevel list, thus worsening the annoying problems with it. Closes RQA-2771
Configuration menu - View commit details
-
Copy full SHA for c955886 - Browse repository at this point
Copy the full SHA c955886View commit details -
fix(api): use extended profiles in PAPI
Use the new thermocycler/runExtendedProfile to implement ThermocyclerContext.execute_profile() at or above protocol api version 2.21. This new version of the command preserves the structure of the thermal cycles and will allow the desktop app and ODD to present appropriate information to the user.
Configuration menu - View commit details
-
Copy full SHA for 39c1250 - Browse repository at this point
Copy the full SHA 39c1250View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c20169 - Browse repository at this point
Copy the full SHA 0c20169View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b23489 - Browse repository at this point
Copy the full SHA 6b23489View commit details -
Configuration menu - View commit details
-
Copy full SHA for 706fc9d - Browse repository at this point
Copy the full SHA 706fc9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdaaadd - Browse repository at this point
Copy the full SHA fdaaaddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7296217 - Browse repository at this point
Copy the full SHA 7296217View commit details -
Update app/src/assets/localization/en/protocol_command_text.json
Co-authored-by: Ed Cormany <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b15a5d4 - Browse repository at this point
Copy the full SHA b15a5d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7740205 - Browse repository at this point
Copy the full SHA 7740205View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a32c8c - Browse repository at this point
Copy the full SHA 0a32c8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb833d6 - Browse repository at this point
Copy the full SHA bb833d6View commit details -
refactor(app): formatDuration improvements
This handles non-normalized durations (i.e., all seconds) now. I think it is janky.
Configuration menu - View commit details
-
Copy full SHA for 12ec9f2 - Browse repository at this point
Copy the full SHA 12ec9f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for edd0c86 - Browse repository at this point
Copy the full SHA edd0c86View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d031a31 - Browse repository at this point
Copy the full SHA d031a31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1007573 - Browse repository at this point
Copy the full SHA 1007573View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ae9ae0 - Browse repository at this point
Copy the full SHA 9ae9ae0View commit details