Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app,api): Display thermocycler profile cycles #16414

Merged
merged 18 commits into from
Oct 8, 2024

Commits on Oct 4, 2024

  1. feat(api): add tc extended profiles to hcapi

    These extended profiles match the way that you can configure a
    thermocycler in protocol designer. They support a mix of cycles (more
    than one per profile) and out-of-cycle steps, while keeping structure
    down to hardware. That last part is sadly important to support
    currently-exposed details up from the hardware controller.
    sfoster1 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    95dd07d View commit details
    Browse the repository at this point in the history
  2. feat(api,shared-data): add runExtendedProfile

    This is a thermocycler command that accepts a structured sequence of
    temperatures and wait times instead of a flat list.
    
    A profile is a list of either steps or cycles; cycles are a repetition
    count plus a list of steps.
    
    The actual _functionality_ of the command is exactly the same as
    thermocycler/runProfile; the only change is pushing down the structure
    of the information, which is currently lost when creating a runProfile
    command and thus unavailable to protocol clients for display.
    sfoster1 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f0eec27 View commit details
    Browse the repository at this point in the history
  3. fix(app): update thermocycler command text

    This PR does a couple things with thermocycler command text.
    
    First, it changes the phrasing of the thermocycler/runProfile command
    text to make it more clear that no cycles are involved: it's just a big
    list of steps.
    
    Second, it adds a command text for the new
    thermocycler/runExtendedProfile command, which does have the structured
    data necessary to render things as cycles. This unfortunately makes it a
    multilevel list, thus worsening the annoying problems with it.
    
    Closes RQA-2771
    sfoster1 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c955886 View commit details
    Browse the repository at this point in the history
  4. fix(api): use extended profiles in PAPI

    Use the new thermocycler/runExtendedProfile to implement
    ThermocyclerContext.execute_profile() at or above protocol api version
    2.21.
    
    This new version of the command preserves the structure of the thermal
    cycles and will allow the desktop app and ODD to present appropriate
    information to the user.
    sfoster1 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    39c1250 View commit details
    Browse the repository at this point in the history
  5. wrong import

    sfoster1 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0c20169 View commit details
    Browse the repository at this point in the history
  6. fix test and add new entry

    sfoster1 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    6b23489 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    706fc9d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fdaaadd View commit details
    Browse the repository at this point in the history
  9. fixup: remove shebang

    sfoster1 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7296217 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b15a5d4 View commit details
    Browse the repository at this point in the history
  11. i should fix this

    sfoster1 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7740205 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    0a32c8c View commit details
    Browse the repository at this point in the history
  13. some very specific tests

    sfoster1 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    bb833d6 View commit details
    Browse the repository at this point in the history
  14. refactor(app): formatDuration improvements

    This handles non-normalized durations (i.e., all seconds) now. I think
    it is janky.
    sfoster1 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    12ec9f2 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    edd0c86 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. single digit hours

    sfoster1 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d031a31 View commit details
    Browse the repository at this point in the history
  2. whoops

    sfoster1 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    1007573 View commit details
    Browse the repository at this point in the history
  3. whoops x2

    sfoster1 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    9ae9ae0 View commit details
    Browse the repository at this point in the history