Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components, protocol-designer): Fix text wrap issues in PD #16385

Merged
merged 10 commits into from
Oct 1, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Sep 30, 2024

Overview

Fix text wrap issues in PD (not only RQA-3238)

close RQA-3238

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

@koji koji marked this pull request as ready for review September 30, 2024 20:18
@koji koji requested review from a team as code owners September 30, 2024 20:18
@koji koji removed request for a team September 30, 2024 20:19
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! left some comments

protocol-designer/src/pages/ProtocolOverview/index.tsx Outdated Show resolved Hide resolved
return (
<>
<Fragment>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to specify that this is a fragment here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's getting a warning because of the recently eslint change.

@koji koji merged commit 680ee12 into edge Oct 1, 2024
31 checks passed
@koji koji deleted the fix_text-wrap-issues branch October 1, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants