feat (hardware-testing): add JIRA functionality to testing scripts #16013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rclarke0
reviewed
Aug 15, 2024
| with open(raw_path, newline="") as csvfile: | ||
| row_count = sum(1 for row in csvfile) | ||
| tot_error = 0.0 | ||
| max_error = 0.0 |
There was a problem hiding this comment.
remove max_error and min_error
rclarke0
reviewed
Aug 15, 2024
| for count in range(row_count): | ||
| row_of_interest = str(full_list[count + 1]) | ||
| error = float(row_of_interest.split("'")[9]) | ||
| tot_error = tot_error + error |
rclarke0
approved these changes
Aug 15, 2024
nbshiland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request adds a few new features to existing hardware testing scripts and a small bug fix.
Test Plan and Hands on Testing
I ran every new script on robots while initiating errors and trying to break them. All changes to the jira_tool script work with every current references of the script.
Changelog
First, the speed_accel_profile script can now post results and raw data to Jira and print a summary of the test outside of Jira. Next, in the "gripper_and_zmount_move" you can now change the distance, log results, and post results to a Jira ticket. Both of these script changes required a few small changes and additions to the jira_tool script. Also, both of these scripts can be used without Jira integration and outside of ABR. Lastly, a bug in the abr_robot_error script that prevented LPC data from being collected was fixed.
Review requests
Checking message statements and if some functions should be defined in different scripts.
Risk assessment
Not much, this only affects ABR and hardware testing scripts.