Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(abr-testing): Compare LPC of errored labware to LPC data #15637

Merged
merged 1 commit into from
Jul 12, 2024
Merged

feat(abr-testing): Compare LPC of errored labware to LPC data #15637

merged 1 commit into from
Jul 12, 2024

Conversation

rclarke0
Copy link
Contributor

@rclarke0 rclarke0 commented Jul 11, 2024 •
edited
Loading

Overview

Compares LPC of labware in error step to average LPC coordinates of historical runs.

Test Plan

Tested on robots with errors including and excluding labware in their error step.

Changelog

  • Gets LPC coordinates of labware from errored protocol step
  • Connects to ABR LPC sheet
  • Filters data to match robot, labware type, adaptor, module, and slot location
  • Finds average of each coordinate that was not from a run with an error
  • Creates string that is posted in jira ticket description.

Review requests

Risk assessment

@rclarke0 rclarke0 requested a review from a team as a code owner July 11, 2024 21:20
@rclarke0 rclarke0 requested review from a team and sfoster1 July 11, 2024 21:20
sfoster1
sfoster1 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is absolutely brilliant, thank you!

@rclarke0 rclarke0 merged commit 7a9479c into edge Jul 12, 2024
11 checks passed
@rclarke0 rclarke0 deleted the add-lpc-analysis-to-error branch July 12, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rclarke0 @sfoster1