Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): fix stringified runtime parameter value #15574

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

ecormany
Copy link
Contributor

@ecormany ecormany commented Jul 3, 2024

Overview

RTP value was inside quotes. That won't work.

This is a docs hotfix. Once approved and tests pass, the commit from this branch will be tagged, docs deployed, and then this branch will be regular-merged to edge.

Test Plan

Sandbox – make sure no references to 2.20 here

@ecormany ecormany requested a review from a team as a code owner July 3, 2024 15:56
@ecormany ecormany requested a review from ncdiehl11 July 3, 2024 15:56
Copy link
Contributor

github-actions bot commented Jul 3, 2024

A PR has been opened to address analyses snapshot changes. Please review the changes here: https://github.com/Opentrons/opentrons/pull/

Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

github-actions bot commented Jul 3, 2024

A PR has been opened to address analyses snapshot changes. Please review the changes here: https://github.com/Opentrons/opentrons/pull/

Copy link
Collaborator

@y3rsh y3rsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore the analyses tests. They are triggered because of where the changed file lives but I think because you don't have latest edge in your branch, the newly located and refactored tests cause the test to fail at an unexpected step and the comment gets added and should not.

@sfoster1 sfoster1 merged commit bdf3d37 into edge Jul 3, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants