fix(app): fix password button rendering issue and update input field component #15145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji
changed the title
mjhuff
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
the issue is that when tapping the eye icon button, the entire screen is re-rendered and the caret is move to the left from the right.
use React.memo for this.
Introducing forwardRef to control
focus()instead of using React event.I think using ref would bring more flexibility to us.
remove secondary caption since it seems that secondary caption is just taken over from the original component which is
library/inputfieldand Mel askedwhy do we need that?InputField component is existing in
appright now but this should be moved intocomponents.Mel is requesting us to update Storybook. I think I will move input field into components after 7.3.0 and update stories and test cases.
close RQA-2697
Test Plan
Changelog
Review requests
Risk assessment