chore(api-client): run api-client tests in ci #15083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
reviewed
Jun 26, 2024
| @@ -59,8 +59,8 @@ jobs: | |||
| npm config set cache ./.npm-cache | |||
| yarn config set cache-folder ./.yarn-cache | |||
| make setup-js | |||
| - name: 'run react-api-client unit tests' | |||
| run: make -C react-api-client test-cov | |||
| - name: 'run api-client unit tests' | |||
sfoster1
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
we haven't been running (the minimal) api-client tests in CI. this changes that.
make -C api-client testruns both api-client and react-api-client tests.Test Plan
verified that api-client tests are running in CI
Changelog
Review requests
check that api-client tests are running in CI
Risk assessment
low