Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): update specific analysis keys passed through CommandText with terminal run record #15079

Merged
merged 4 commits into from
May 6, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented May 2, 2024

closes RQA-2645
closes RQA-2647

Overview

We now grab commands for terminal runs from the run record rather than the most recent completed analysis to give a more accurate representation of the commands actually executed during a run. However, this introduced some unintended downstream bugs in CommandText and its utilities for hashing commands by labware, pipette, and module IDs— the run commands' IDs no longer match those contained in the analysis's labware, pipette, and module values.

To address this, here, I overwrite those properties in the robot-side analysis that is passed to CommandText and all of its children/utilities so that the command param IDs can be properly hashed.

Test Plan

  • run a protocol, like flex_MOAM_218.py linked here
  • observe that the running protocol command text is formatted properly
  • allow the run to finish or cancel the run
  • observe that the terminal protocol commands go only up to the last command actually executed, and the text formatted properly, including all labware display names and locations

Changelog

  • overwrite labware, modules, and pipettes data on analysis if run is terminal and run record data is not null

Review requests

@shlokamin per working on previous fix

Risk assessment

medium

@ncdiehl11 ncdiehl11 requested a review from shlokamin May 2, 2024 20:21
@ncdiehl11 ncdiehl11 self-assigned this May 2, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review May 2, 2024 20:22
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner May 2, 2024 20:22
@koji koji added the authorship label May 3, 2024
@jerader
Copy link
Collaborator

jerader commented May 3, 2024

should this be targeting edge or the release branch?

Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@ncdiehl11
Copy link
Collaborator Author

should this be targeting edge or the release branch?

release, thank you!

@ncdiehl11 ncdiehl11 force-pushed the fix_app-command-text-terminal branch from 83799ed to 980513e Compare May 6, 2024 14:15
@ncdiehl11 ncdiehl11 changed the base branch from edge to chore_release-7.3.0 May 6, 2024 14:16
@ncdiehl11 ncdiehl11 merged commit a88f03b into chore_release-7.3.0 May 6, 2024
48 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-command-text-terminal branch May 6, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants