fix(app): update specific analysis keys passed through CommandText with terminal run record #15079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-2645
closes RQA-2647
Overview
We now grab commands for terminal runs from the run record rather than the most recent completed analysis to give a more accurate representation of the commands actually executed during a run. However, this introduced some unintended downstream bugs in
CommandText
and its utilities for hashing commands by labware, pipette, and module IDs— the run commands' IDs no longer match those contained in the analysis's labware, pipette, and module values.To address this, here, I overwrite those properties in the robot-side analysis that is passed to
CommandText
and all of its children/utilities so that the command param IDs can be properly hashed.Test Plan
Changelog
Review requests
@shlokamin per working on previous fix
Risk assessment
medium