fix(app): ODD fixture removal, mag block with staging in deck map, add modules to drop tip wizard #15019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fixture name At the beginning of the module calibration flow, the user is asked to locate the module on the deck. This integrated the deck configurator component directly into this location selction step of the module calibration wizard. the selected location will now be saved directly to deck configuration. Closes RQA-2603
…g protocol setup on ODD Resolve location conflicts in the on device display's protocol setup flow by updating deck configuration accordingly. Closes PLAT-287
…d modules to drop tip wizard Fix three bugs associated with the addition of modules to deck configuration. First repair the ODD's deck configurator such that local changes are staged properly. Second, properly display the mag block when loaded into a staging area fixture on the base deck component. Lastly, fix drop tip wizard in the case of a configured module. Closes RQA-2622, Closes RQA-2638
brenthagen
reviewed
Apr 26, 2024
Comment on lines
+118
to
+120
| (fixture.cutoutFixtureId === STAGING_AREA_RIGHT_SLOT_FIXTURE || | ||
| fixture.cutoutFixtureId === | ||
| STAGING_AREA_SLOT_WITH_MAGNETIC_BLOCK_V1_FIXTURE) && |
There was a problem hiding this comment.
for consistency we could do a constant STAGING_AREA_FIXTURES and a STAGING_AREA_FIXTURES.includes(fixture.cutoutFixtureId) filter check like we do for the other fixture types
There was a problem hiding this comment.
I'll add a comment so we can come back to this, not too familiar with the stating areas vs cutouts.
brenthagen
approved these changes
Apr 26, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
…d modules to drop tip wizard (#15019)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix three bugs associated with the addition of modules to deck configuration. First repair the ODD's
deck configurator such that local changes are staged properly. Second, properly display the mag
block when loaded into a staging area fixture on the base deck component. Lastly, fix drop tip
wizard in the case of a configured module.
Closes RQA-2622, Closes RQA-2638
Review Requests
Risk assessment
low