-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): Raise cases for unsupported nozzle layouts #15009
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a58d2ac
doc updates and addition of raise cases for unsupported nozzle layouts
CaseyBatten 6768ca9
test updates and doc removals
CaseyBatten 9f2ba9f
nozzle manager test corrections
CaseyBatten 15b0fdb
gravimetric test fix to utilize engine configuration
CaseyBatten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -1928,13 +1928,6 @@ def configure_nozzle_layout( | |||||
should be of the same format used when identifying wells by name. | ||||||
Required unless setting ``style=ALL``. | ||||||
|
||||||
.. note:: | ||||||
When using the ``COLUMN`` layout, the only fully supported value is | ||||||
``start="A12"``. You can use ``start="A1"``, but this will disable tip | ||||||
tracking and you will have to specify the ``location`` every time you | ||||||
call :py:meth:`.pick_up_tip`, such that the pipette picks up columns of | ||||||
tips *from right to left* on the tip rack. | ||||||
|
||||||
:type start: str or ``None`` | ||||||
:param tip_racks: Behaves the same as setting the ``tip_racks`` parameter of | ||||||
:py:meth:`.load_instrument`. If not specified, the new configuration resets | ||||||
|
@@ -1947,6 +1940,20 @@ def configure_nozzle_layout( | |||||
# :param front_right: The nozzle at the front left of the layout. Only used for | ||||||
# NozzleLayout.QUADRANT configurations. | ||||||
# :type front_right: str or ``None`` | ||||||
# | ||||||
# NOTE: Disabled layouts error case can be removed once desired map configurations | ||||||
# have appropriate data regarding tip-type to map current values added to the | ||||||
# pipette definitions. | ||||||
disabled_layouts = [ | ||||||
NozzleLayout.ROW, | ||||||
NozzleLayout.SINGLE, | ||||||
NozzleLayout.QUADRANT, | ||||||
] | ||||||
if style in disabled_layouts: | ||||||
raise ValueError( | ||||||
f"Nozzle layout configuration of style {style.value} is currently unsupported." | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. copy suggestion
Suggested change
|
||||||
) | ||||||
|
||||||
if style != NozzleLayout.ALL: | ||||||
if start is None: | ||||||
raise ValueError( | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy suggestion