Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(performance-metrics): separate storage logic from tracker #14982

Merged
merged 9 commits into from
Apr 26, 2024

Conversation

DerekMaggio
Copy link
Contributor

Overview

Closes https://opentrons.atlassian.net/browse/EXEC-415

  • Pulls out storage logic from tracker into MetricsStore object
  • Defines MetricsMetadata to store information about the MetricsStore object

Test Plan

  • Modified file storage test in performance-metrics to use the new classes.
    • Loads file content and validates it
  • Modified test_track_analysis test in api/test_cli
    • Loads file content and validates it

Changelog

  • Create MetricsMetadata in shared data which defines where to store data, what to call it, and the headers
  • Create MetricsStore which handles creating any necessary directories or files and then storing data to the files
  • Remove storage logic from RobotContextTracker then instantiate MetricsStore and call to its methods to handle data storage

Review requests

None

Risk assessment

Low

@DerekMaggio DerekMaggio self-assigned this Apr 23, 2024
@DerekMaggio DerekMaggio requested a review from a team as a code owner April 23, 2024 15:59
@DerekMaggio DerekMaggio force-pushed the EXEC-415-performance_metrics_data_store branch from 7985dc7 to 9789604 Compare April 24, 2024 13:15
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, nice use of a typevar!

@DerekMaggio DerekMaggio merged commit ce1e64a into edge Apr 26, 2024
66 checks passed
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
…14982)

# Overview

Closes https://opentrons.atlassian.net/browse/EXEC-415

- Pulls out storage logic from tracker into MetricsStore object
- Defines MetricsMetadata to store information about the MetricsStore
object

# Test Plan

- Modified file storage test in performance-metrics to use the new
classes.
  - Loads file content and validates it 
- Modified test_track_analysis test in api/test_cli 
  - Loads file content and validates it 

# Changelog

- Create MetricsMetadata in shared data which defines where to store
data, what to call it, and the headers
- Create MetricsStore which handles creating any necessary directories
or files and then storing data to the files
- Remove storage logic from RobotContextTracker then instantiate
MetricsStore and call to its methods to handle data storage

# Review requests

None

# Risk assessment

Low
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants