Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): ensure the right mount is enabled for initial homing #14822

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

caila-marashaj
Copy link
Contributor

@caila-marashaj caila-marashaj commented Apr 5, 2024

Overview

On the current main firmware, the 96 channel will fail to home after startup or initial attachment, and as a result won't be able to proceed with protocols or testing.

This pr is a temporary holdover that is tested and fixes the issue from the Python side, and should be removed when a firmware solution is figured out.

Changelog

  • if _home_axis is called on the right mount, ensure that a request to engage the motor is sent before the move is executed.

@caila-marashaj caila-marashaj requested a review from a team as a code owner April 5, 2024 21:25
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.24%. Comparing base (65885b2) to head (8fc43b9).
Report is 6 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14822      +/-   ##
==========================================
- Coverage   67.24%   67.24%   -0.01%     
==========================================
  Files        2495     2495              
  Lines       71254    71249       -5     
  Branches     8937     8937              
==========================================
- Hits        47918    47914       -4     
+ Misses      21235    21234       -1     
  Partials     2101     2101              
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/src/opentrons/hardware_control/ot3api.py 79.55% <ø> (ø)

@caila-marashaj caila-marashaj merged commit 8f50b08 into edge Apr 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants