-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix settings tests #14810
Fix settings tests #14810
Conversation
When we patch the _read_settings_file function we are not including flags that are set to internal_only=True.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## EXEC-372-hide-performance-metrics-project-behind-ff #14810 +/- ##
======================================================================================
Coverage ? 67.24%
======================================================================================
Files ? 2495
Lines ? 71254
Branches ? 8937
======================================================================================
Hits ? 47918
Misses ? 21235
Partials ? 2101
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty, good catch!
be0683b
into
EXEC-372-hide-performance-metrics-project-behind-ff
# Overview When we patch the _read_settings_file function, we are calling to fixtures that exclude flags that have internal_only set to True. When you look at the _read_settings_file function there is no filtering out of flags set to internal_only. ```python def _read_settings_file(settings_file: "Path") -> SettingsData: """ Read the settings file, which is a json object with settings IDs as keys and boolean values. For each key, look up the `Settings` object with that key. If the key is one of the old IDs (kebab case), replace it with the new ID and rewrite the settings file :param settings_file: the path to the settings file :return: a dict with all new settings IDs as the keys, and boolean values (the values stored in the settings file, or `False` if the key was not found). Along with the version. """ # Read settings from persistent file data = _read_json_file(settings_file) settings, version = _migrate(data) settings = _ensure(settings) if data.get("_version") != version: _write_settings_file(settings, version, settings_file) return SettingsData(settings_map=settings, version=version) ``` Therefore, the patches for the OT-2 and Flex should be calling the fixtures that do not exclude the internal_only flag.
# Overview When we patch the _read_settings_file function, we are calling to fixtures that exclude flags that have internal_only set to True. When you look at the _read_settings_file function there is no filtering out of flags set to internal_only. ```python def _read_settings_file(settings_file: "Path") -> SettingsData: """ Read the settings file, which is a json object with settings IDs as keys and boolean values. For each key, look up the `Settings` object with that key. If the key is one of the old IDs (kebab case), replace it with the new ID and rewrite the settings file :param settings_file: the path to the settings file :return: a dict with all new settings IDs as the keys, and boolean values (the values stored in the settings file, or `False` if the key was not found). Along with the version. """ # Read settings from persistent file data = _read_json_file(settings_file) settings, version = _migrate(data) settings = _ensure(settings) if data.get("_version") != version: _write_settings_file(settings, version, settings_file) return SettingsData(settings_map=settings, version=version) ``` Therefore, the patches for the OT-2 and Flex should be calling the fixtures that do not exclude the internal_only flag.
Overview
When we patch the _read_settings_file function, we are calling to fixtures that exclude flags that have internal_only set to True. When you look at the _read_settings_file function there is no filtering out of flags set to internal_only.
Therefore, the patches for the OT-2 and Flex should be calling the fixtures that do not exclude the internal_only flag.