fix(api): Change the camera device based on system version #14789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addition of ignoreTipConfiguration flags
Trashbin support is required for API 2.16
Co-authored-by: y3rsh <[email protected]>
There were 2 issues that prevented this dockerfile from building: 1) The base ubuntu image doesn't have git installed. This is required by `./scripts/python_build_utils.py` when normalizing version strings in setup.py 2) robot-server depends on server-utils but that was never copied or installed in the dockerfile
The current "out-of-the-box" dev experience fails in the following way - `make setup` first invokes - `make setup-js` before it runs `make setup-py` - setup-js invokes a sub-make for the app shell which requires pipenv already setup to build the python protocol analysis sandbox. This is fine if you've already run things before and have pipenv installed locally but it means the standard experience following the dev guides fails. This pulls out the minimal python setup as a dependency of both the setup-py and setup-js build targets
…ation protocols (#13620)
…s values keyed by tip count (#14458) * pickUpTipConfigurations' speed and distance are now objects keyed by tip count * updated to speedByTipCount and distanceByTipCount in all pipette defs * updated schema v1 build script * updated mutable configs handlers * updated hardware_testing/helpers_ot3
Resolve conflicts in Makefile.
* revert 2.17 changes * fix trash line on homepage * named location arg
Co-authored-by: y3rsh <[email protected]>
Co-authored-by: Ed Cormany <[email protected]>
This is a merge of the in-process release to capture fixes to Python CI workflows
…14533) revert back to connect function in step edit form to avoid stale props and zombie children
…o robot server (#14766) Closes EXEC-358 Wire up PE event bubbling to the robot server for notifications as an alternative to the current polling that occurs. There are no functional changes. PublisherNotifier is the new interface that handles event management for publishers, using a generic ChangeNotifier that is given to PE as a callback. When PE reports a change in state, the callback fires. PublisherNotifier then iterates through each callback, invoking them. In the future, each publisher that requires access to PE state updates (eg, RunsPublisher) will add relevant callbacks during their initialization via register_publish_callbacks. Each callback will contain the conditional logic required for an MQTT publish to occur.
* fix(app,shared-data): change type name from boolean to bool
* fix(app): fix storybook build error
sfoster1
approved these changes
Apr 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.2 #14789 +/- ##
=======================================================
- Coverage 67.56% 67.19% -0.37%
=======================================================
Files 2521 2495 -26
Lines 72251 71381 -870
Branches 9311 8981 -330
=======================================================
- Hits 48815 47968 -847
- Misses 21240 21301 +61
+ Partials 2196 2112 -84
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vegano1
force-pushed
the
EXEC-354-camera-device
branch
from
e2df55a
to
27c59f5
Compare
|
curl -X POST --header "opentrons-version: 3" 127.0.0.1:31950/camera/picture --output "picture1.jpg"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We updated the Linux Kernel recently which has changed the camera device from /dev/video0 to /dev/video2, so lets change it here. This pull request pertains to Opentrons/oe-core#140.
Closes: EXEC-354
Test Plan
/camera/pictureendpoint.Changelog
Review requests
Risk assessment