Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix ODD "run again" routing #14694

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Mar 19, 2024

Closes RABR-179

Overview

Clicking "run again" repeatedly causes multiple cloneRun hooks to fire, resulting in sometimes bizarre routing scenarios. If a cloneRun is in progress, do not let another cloneRun occur.

Test Plan

  • On the ODD, finish a protocol run, then click run again repeatedly. You should still be directed to the RunSetup page with no strange intermediate pages.

Changelog

  • Fixed pressing the "Run again" button the ODD sometimes briefly routing to unexpected places.

Risk assessment

low

Clicking "run again" repeatedly causes multiple cloneRun hooks to fire, resulting in sometimes
bizzare routing scenarios. If a cloneRun is in progress, do not let another cloneRun occur.
@mjhuff mjhuff requested a review from a team March 19, 2024 19:28
@mjhuff mjhuff requested a review from a team as a code owner March 19, 2024 19:28
@mjhuff mjhuff requested review from TamarZanzouri and koji and removed request for a team and TamarZanzouri March 19, 2024 19:28
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense to me.
I tested this PR on a Flex and the app worked as expected.
thank you for fixing this.

@mjhuff mjhuff merged commit 8e4ffb9 into edge Mar 19, 2024
26 checks passed
@mjhuff mjhuff deleted the app_fix-run-again-routing branch March 19, 2024 21:09
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
Closes RABR-179

Clicking "run again" repeatedly causes multiple cloneRun hooks to fire, resulting in sometimes bizarre routing scenarios. If a cloneRun is in progress, do not let another cloneRun occur.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants