Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): border radius overrides feedback #14680

Merged
merged 5 commits into from
Mar 18, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Mar 18, 2024

Closes EXEC-332, EXEC-330, and EXEC-333

Overview

This PR addresses Mel's feedback for components either unaccounted by designs or that were not properly addressed on the first pass.

Test Plan

  • If you'd like, verify that the code fixes the comments left by Mel in each of the tickets.
  • Note that proof of life work refers to taking screenshots (it's not covered by this PR).

Risk assessment

low

@mjhuff mjhuff requested review from a team March 18, 2024 15:26
@mjhuff mjhuff requested a review from a team as a code owner March 18, 2024 15:26
@mjhuff mjhuff requested review from shlokamin and removed request for a team and shlokamin March 18, 2024 15:26
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@mjhuff mjhuff merged commit fe9a09f into edge Mar 18, 2024
33 checks passed
@mjhuff mjhuff deleted the app_border-radius-overrides-feedback branch March 18, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants