Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): runtime parameters API for adding and using default parameters in protocols #14668

Merged
merged 20 commits into from
Mar 19, 2024
Merged

feat(api): runtime parameters API for adding and using default parameters in protocols #14668

merged 20 commits into from
Mar 19, 2024

Commits on Mar 7, 2024

  1. first draft of parameter definition

    @jbleon95
    jbleon95 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    d3e0d47 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Merge branch 'edge' of https://github.com/Opentrons/opentrons into rt… 

    …p_papi_parameter_definitions
    @jbleon95
    jbleon95 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    12f39c6 View commit details
    Browse the repository at this point in the history

  2. first pass at parsing and using parameters in python protocols

    @jbleon95
    jbleon95 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    dc0386c View commit details
    Browse the repository at this point in the history

  3. refactor to make run_python less complex

    @jbleon95
    jbleon95 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    27c1c0d View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. refactor parameter definition to have choices be typeddicts

    @jbleon95
    jbleon95 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    02aeb87 View commit details
    Browse the repository at this point in the history

  2. moving around files

    @jbleon95
    jbleon95 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    c57fef3 View commit details
    Browse the repository at this point in the history

  3. more refactoring of files and locations

    @jbleon95
    jbleon95 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    7267f83 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. add more of context api and refactor parameter definition creation

    @jbleon95
    jbleon95 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    eaf50e1 View commit details
    Browse the repository at this point in the history

  2. set parameters as properties to prevent overwriting them in a protocol

    @jbleon95
    jbleon95 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    dc9cdcd View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. more validation of string arguments for parameter definitions

    @jbleon95
    jbleon95 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    7d2df0b View commit details
    Browse the repository at this point in the history

  2. unit test for parameter context

    @jbleon95
    jbleon95 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    0c27903 View commit details
    Browse the repository at this point in the history

  3. refactoring file locations

    @jbleon95
    jbleon95 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    b6f8a79 View commit details
    Browse the repository at this point in the history

  4. unit tests for creating parameter definitions

    @jbleon95
    jbleon95 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e57c1a4 View commit details
    Browse the repository at this point in the history

  5. fixing up/removing todos

    @jbleon95
    jbleon95 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5fd67cc View commit details
    Browse the repository at this point in the history

  6. tests for parameter validation

    @jbleon95
    jbleon95 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    ec3adda View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. changes per code review

    @jbleon95
    jbleon95 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    7ce24a5 View commit details
    Browse the repository at this point in the history

  2. more changes in response to review

    @jbleon95
    jbleon95 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ee05c22 View commit details
    Browse the repository at this point in the history

  3. refactor parameter dynamic attribute setting to not set class level

    @jbleon95
    jbleon95 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    88b674f View commit details
    Browse the repository at this point in the history

  4. add parameters to init

    @jbleon95
    jbleon95 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    e7c6cef View commit details
    Browse the repository at this point in the history

  5. exclude params from docs for now

    @jbleon95
    jbleon95 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    6eba3d5 View commit details
    Browse the repository at this point in the history