Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): Remove failed command state #14664

Closed

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Mar 14, 2024

Overview

This goes towards EXEC-301.

This removes this piece of internal Protocol Engine state:

failed_command: Optional[CommandEntry]
"""The command, if any, that made the run fail and the index in the command list."""

It's only used as a pagination helper for robot-server, and it's sort of semantically problematic in a world where a run has many failed commands and none of them are necessarily fatal.

Test Plan

To do.

Changelog

To do.

Review requests

To do.

Risk assessment

To do.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (nonfatal_errors_refactors@5f024d9). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##             nonfatal_errors_refactors   #14664   +/-   ##
============================================================
  Coverage                             ?   67.33%           
============================================================
  Files                                ?     2485           
  Lines                                ?    71416           
  Branches                             ?     9057           
============================================================
  Hits                                 ?    48091           
  Misses                               ?    21173           
  Partials                             ?     2152           
Flag Coverage Δ
g-code-testing 92.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pi/src/opentrons/protocol_engine/state/commands.py 99.36% <ø> (ø)
robot-server/robot_server/commands/router.py 100.00% <ø> (ø)
...server/robot_server/runs/router/commands_router.py 100.00% <ø> (ø)

@SyntaxColoring
Copy link
Contributor Author

Closing for now: this tempts us down a robot-server pagination rabbithole that doesn't seem productive right now. I'll go with a different approach that doesn't involve removing this piece of state.

@SyntaxColoring SyntaxColoring deleted the remove_failed_command_state branch May 31, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant