refactor(api): Remove failed command state #14664
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This goes towards EXEC-301.
This removes this piece of internal Protocol Engine state:
opentrons/api/src/opentrons/protocol_engine/state/commands.py
Lines 155 to 156 in 7689521
It's only used as a pagination helper for robot-server, and it's sort of semantically problematic in a world where a run has many failed commands and none of them are necessarily fatal.
Test Plan
To do.
Changelog
To do.
Review requests
To do.
Risk assessment
To do.