Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): Border radius helix migration - find and replace #14659

Merged
merged 8 commits into from
Mar 14, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Mar 14, 2024

Closes EXEC-323, EXEC-324, EXEC-325, EXEC-326, EXEC-327, EXEC-328

Overview

This PR is the big find and replace for border radius migraiton work. It follows the same pattern that we used for color migration. Not everything will be perfect, but this PR covers most of the migration.

The next step will be to work on the special cases. After that, DQA.

Test Plan

  • Not too much to do here. In the Epic, you can peruse the figma file and especially the 1:1 migration guide to see what was found and replaced.

Risk assessment

low

@mjhuff mjhuff requested a review from a team March 14, 2024 16:59
@mjhuff mjhuff requested a review from a team as a code owner March 14, 2024 16:59
@mjhuff mjhuff requested review from a team, TamarZanzouri, koji and ncdiehl11 and removed request for a team and TamarZanzouri March 14, 2024 16:59
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mjhuff mjhuff merged commit b882d61 into edge Mar 14, 2024
52 checks passed
@mjhuff mjhuff deleted the app_border-radius-helix-migration branch March 14, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants