Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(monorepo): remove jest-styled-components #14618

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Mar 9, 2024

Overview

remove jest-styled-components
https://opentrons.atlassian.net/browse/AUTH-82

Test Plan

the following commands work as expect

  • make check-js
  • make lint-js
  • make lint-css
  • make test-js

Changelog

Review requests

Risk assessment

low

remove jest-styled-components
@koji koji requested a review from a team March 9, 2024 00:16
@koji koji marked this pull request as ready for review March 9, 2024 00:17
@koji koji requested review from a team as code owners March 9, 2024 00:17
@koji koji requested review from jerader, shlokamin, ncdiehl11 and mjhuff and removed request for a team March 9, 2024 00:17
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for removing this

@@ -1,7 +1,7 @@
// mock electron-store
'use strict'
import { vi } from 'vitest'
import { DEFAULTS_V12, migrate } from '../app-shell-odd/src/config/migrate'
// import { DEFAULTS_V12, migrate } from '../app-shell-odd/src/config/migrate'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line will be cleared by another PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, thanks for clarifying!

@koji koji merged commit 1854842 into edge Mar 11, 2024
26 of 28 checks passed
@koji koji deleted the chore_remove-jest-styled-components branch March 11, 2024 16:23
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* chore(monorepo): remove jest-styled-components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants