-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer, step-generation): support for selecting multi tipracks per pipette #14601
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #14601 +/- ##
==========================================
+ Coverage 67.20% 67.65% +0.45%
==========================================
Files 2495 2514 +19
Lines 71549 72332 +783
Branches 9022 9308 +286
==========================================
+ Hits 48085 48937 +852
+ Misses 21342 21160 -182
- Partials 2122 2235 +113
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e592e73
to
f4884da
Compare
protocol-designer/src/components/StepEditForm/fields/TiprackField.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/StepEditForm/fields/TiprackField.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/modals/FilePipettesModal/PipetteFields.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/modals/FilePipettesModal/TiprackOption.tsx
Outdated
Show resolved
Hide resolved
00468cc
to
0cf0059
Compare
0cf0059
to
c234f7d
Compare
protocol-designer/src/components/modals/FilePipettesModal/PipetteFields.tsx
Outdated
Show resolved
Hide resolved
b00d24b
to
0943263
Compare
f0e9068
to
bbc0c95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
const maxAirGapVolume = | ||
getPipetteCapacity(pipetteEntity, tipRack) - minPipetteVolume |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like getPipetteCapacity
should be receiving labwareEntities as the second param. This appears to be a bug @jerader can you look into it?
closes AUTH-11, AUTH-13, AUTH-50
Overview
This PR adds multi tiprack support to PD for both OT-2 and Flex. Now, a user can select up to 3 tipracks per pipette. Only up to 2 tipracks will auto-generate on the deck but user should be allowed to select all selected tipracks from the labware dropdown.
sandbox https://sandbox.designer.opentrons.com/pd_multi-tiprack-support-in-pd/
Test Plan
Create a flex or Ot-2 protocol. check that the tiprack selection page in the wizard allows you to add up to 3 tipracks for both pipettes. See that the protocol is created correctly. Now, test editing the pipettes and tipracks. See that it works correctly. Then go to the deck map and ensure that every tiprack selected is selectable on the labware selection modal for the deckmap.
Add a labware and create a pipetting step (mix or transfer). Make sure all the tipracks for that pipette are selectable in the dropdown. Test switching between 2 tipracks and see that the tip tracking is accurate between the multiple tipracks.
Export the protocol and import it again and ensure that it imports correctly. Then, try importing a json fixture, like
doItAllV8
and see that it migrates correctly.Finally, test the 96-channel. Create a flex protocol with the 96-channel and test out a few transfer/mix steps alternating between the different tip racks.
Changelog
tiprackDefUri
key from a string to an arraytiprackSelect
,tiprackOption
files for selecting tipracksdesignerApplication
and then pass it down to step-generation for thetransfer
,mix
,consolidate
,distribute
CreatePresavedStepForm
for defaulting the tiprack dropdown based on the pipette and add error state to tipRack fieldgetNextTip
logic to accommodate multiple tiprack def URIsReview requests
see test plan
Risk assessment
low - adds lots of code but plenty of time to test before the next release