Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to use raw LLD data to test new algorythms #14595

Merged
merged 11 commits into from
Mar 11, 2024

Conversation

ryanthecoder
Copy link
Contributor

Overview

Test Plan

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested a review from a team as a code owner March 4, 2024 21:49
return (new_running_avg - prev_running_avg) < derivative_threshold_smad

#-----weighted moving average derivative---
import numpy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already have that above right

running_derivative.append(running_avg_derivative)
running_avg.append(average)

# print(running_avg_derivative)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO just keep these prints in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it so that derivative is part of the graph instead

@ryanthecoder ryanthecoder merged commit 8bd9a8b into EXEC-132-lld-project Mar 11, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants