fix(app): poll modules from protocol run module controls #14581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-2419
Overview
Once a run is completed, the module cards on the controls section of the run view were not updating to reflect the most recent module information. This is because we were only polling for modules in the Setup section, which is disabled after the run begins. To fix this, I've enabled polling for modules from the Module Controls tab.
Test Plan
/modules
response every 5 seconds. If you dismiss the run by X'ing the run completed banner, the Module Controls tab should become disabled and this poll should stopChangelog
Add optional
pollModules
param touseModuleRenderInfoForProtcolById
that will polluseAttachedModules
every 5 seconds when truePass this prop as
true
fromProtocolRunModuleControls
Review requests
Test this out and look over change
Risk assessment
Low