revert(app): Privacy policy changes and opt-in strategy

[b-cooper]

Overview

Revert changes to the privacy settings toggle messaging and prompts in the Desktop and On Device Display apps. Behavior should be consistent with 7.1.1 as far as opting-in/out of analytics.

Review requests

• Confirm that there is nothing unintentional reverted within the 4 constituent commits.

Risk assessment

low

[codecov]

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (f30f52a) 67.74% compared to head (cf86c70) 67.75%.

Additional details and impacted files

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14537      +/-   ##
=======================================================
+ Coverage                67.74%   67.75%   +0.01%     
=======================================================
  Files                     2517     2521       +4     
  Lines                    72087    72121      +34     
  Branches                  9284     9284              
=======================================================
+ Hits                     48834    48867      +33     
  Misses                   21035    21035              
- Partials                  2218     2219       +1     

Flag	Coverage Δ
app	64.69% <64.78%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
app/src/App/OnDeviceDisplayApp.tsx	76.66% <ø> (ø)
...nisms/Devices/hooks/useProtocolRunAnalyticsData.ts	64.70% <100.00%> (+1.06%)	⬆️
...ms/Devices/hooks/useTrackCreateProtocolRunEvent.ts	81.81% <ø> (-1.52%)	⬇️
...rganisms/Devices/hooks/useTrackProtocolRunEvent.ts	88.88% <ø> (-1.12%)	⬇️
...sms/OnDeviceDisplay/NameRobot/ConfirmRobotName.tsx	100.00% <ø> (ø)
app/src/pages/AppSettings/index.tsx	85.71% <ø> (ø)
app/src/pages/ConnectViaEthernet/index.tsx	68.75% <ø> (ø)
app/src/pages/ConnectViaUSB/index.tsx	88.88% <ø> (ø)
app/src/pages/ConnectViaWifi/index.tsx	84.37% <ø> (ø)
app/src/pages/Devices/RobotSettings/index.tsx	85.71% <100.00%> (+1.09%)	⬆️
... and 13 more

... and 2 files with indirect coverage changes

[jerader]

Privacy tab seems to be fine & working as expected everywhere except for here. Not sure why, i'll dig into it.

[jerader]

Privacy tab seems to be fine & working as expected everywhere except for here. Not sure why, i'll dig into it.

@b-cooper I did some digging, do we need to add log aggregation back? Looks like its not being returned from the getRobotSettings selector.

[jerader]

approving since we discussed on slack that the bug I commented about seems dev server specific.