refactor(protocol-designer): nicknames now properly import

[jerader]

closes RQA-2358, RQA-1927

Overview

This bug has been reported by Support numerous times so it is a high priority bug to get in with the next PD release. Looking into it, its definitely a bug I introduced 7 months ago by accidentally listing the container info via the labware's loadname instead of the labware Id. Oops.

Test Plan

Create a protocol either flex or ot-2. When adding a labware, add a nickname. Also add duplicate tipracks. Add a command that uses the trash. Export. Import the protocol, see that the nicknames on the labware and the tiprack (the numbering at the end of the tiprack) are preserved.

Changelog

• fix the reducer to list the containers via the labware Id instead of the loadname

Review requests

see test plan

Risk assessment

low

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (cb0d4e6) 67.81% compared to head (ace61a9) 67.80%.

Additional details and impacted files

@@            Coverage Diff             @@
##             edge   #14521      +/-   ##
==========================================
- Coverage   67.81%   67.80%   -0.01%     
==========================================
  Files        2518     2518              
  Lines       72108    72111       +3     
  Branches     9274     9276       +2     
==========================================
  Hits        48898    48898              
- Misses      20995    20998       +3     
  Partials     2215     2215              

Flag	Coverage Δ
protocol-designer	37.92% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ocol-designer/src/labware-ingred/reducers/index.ts	21.51% <0.00%> (-0.85%)	⬇️

[koji]

tested and the sandbox worked as expected.

• numbers were displayed
• nick names were displayed on Desktop app