Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ci setup-py #14517

Merged
merged 5 commits into from
Feb 16, 2024
Merged

chore: fix ci setup-py #14517

merged 5 commits into from
Feb 16, 2024

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Feb 16, 2024

CI's setup-py step has been failing with mysterious pipenv problems. It also only fails once. So try again if it fails. I am not proud

Also somehow an empty notify-server workflow got snuck back in, so remove it

@sfoster1 sfoster1 requested a review from a team as a code owner February 16, 2024 17:29
@sfoster1 sfoster1 requested a review from a team February 16, 2024 17:29
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f5c9d0) 67.74% compared to head (1dfbcf9) 67.74%.
Report is 7 commits behind head on chore_release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.2.0   #14517   +/-   ##
====================================================
  Coverage                67.74%   67.74%           
====================================================
  Files                     2517     2517           
  Lines                    72068    72068           
  Branches                  9278     9278           
====================================================
  Hits                     48823    48823           
  Misses                   21027    21027           
  Partials                  2218     2218           
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)
hardware 57.30% <ø> (ø)
hardware-testing ∅ <ø> (∅)
shared-data 75.26% <ø> (ø)
system-server 96.04% <ø> (ø)
update-server 50.56% <ø> (ø)
usb-bridge 76.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird

@sfoster1 sfoster1 merged commit 7cdb342 into chore_release-7.2.0 Feb 16, 2024
41 checks passed
@sfoster1 sfoster1 deleted the fix-pipenv-windows branch February 16, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants