fix(app): return calibration flow even if pipette is already calibrated #14506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14506 +/- ##
=======================================================
- Coverage 67.74% 67.74% -0.01%
=======================================================
Files 2517 2517
Lines 72068 72066 -2
Branches 9278 9278
=======================================================
- Hits 48823 48819 -4
Misses 21027 21027
- Partials 2218 2220 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mjhuff
approved these changes
Feb 15, 2024
| expect( | ||
| getPipetteWizardStepsForProtocol({ left: null, right: null }, [], LEFT) | ||
| ).toStrictEqual(mockFlowSteps) | ||
| }) | ||
| it('returns the calibration flow only when correct pipette is attached but there is no pip cal data', () => { | ||
| it('returns the calibration flow only when correct pipette is attached even if htere is pip cal data', () => { |
There was a problem hiding this comment.
Suggested change
| it('returns the calibration flow only when correct pipette is attached even if htere is pip cal data', () => { | |
| it('returns the calibration flow only when correct pipette is attached even if there is pip cal data', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-2357
Overview
In setup to run when a pipette is correctly attached and calibrated, we should still open the calibration flow when the user presses "recalibrate"
Test Plan
On ODD, with a pipette attached and calibrated, go to run setup and press "Recalibrate" - the calibration flow should launch as expected
Changelog
getPipetteWizardStepsForProtocolif a pipette is properly attached, regardless of whether it is already calibratednullinstead of[]for bothgetPipetteWizardStepsForProtocolandgetPipetteWizardStepsto take advantage of null handling in thePipetteWizardFlowscomponentReview requests
Look over code - I've already tested this
Risk assessment
Low