Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): Remove notification event emitters #14504

Merged
merged 3 commits into from
Feb 16, 2024

clean up callback

099e1d3
Select commit
Loading
Failed to load commit list.
Merged

refactor(app): Remove notification event emitters #14504

clean up callback
099e1d3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 16, 2024 in 1s

67.81% (+0.06%) compared to 9dc8f2d

View this Pull Request on Codecov

67.81% (+0.06%) compared to 9dc8f2d

Details

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9dc8f2d) 67.74% compared to head (099e1d3) 67.81%.
Report is 5 commits behind head on chore_release-7.2.0.

❗ Current head 099e1d3 differs from pull request most recent head f3a2bb3. Consider uploading reports for the commit f3a2bb3 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14504      +/-   ##
=======================================================
+ Coverage                67.74%   67.81%   +0.06%     
=======================================================
  Files                     2517     2517              
  Lines                    72068    72082      +14     
  Branches                  9278     9292      +14     
=======================================================
+ Hits                     48823    48879      +56     
+ Misses                   21027    21001      -26     
+ Partials                  2218     2202      -16     
Files Coverage Δ
app/src/redux/shell/remote.ts 0.00% <0.00%> (ø)
app/src/resources/useNotifyService.ts 38.46% <0.00%> (+2.74%) ⬆️

... and 2 files with indirect coverage changes