Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): Update reference docs for ProtocolContext.pause() #14500

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Feb 15, 2024

Changelog

ProtocolContext.pause() has confusing (RESC-165, RESC-201) behavior on Python Protocol API version 2.13 and below. This was documented, but we didn't document that it's fixed in Protocol API v2.14. Do that here.

Review requests

None in particular.

Risk assessment

No risk.

@SyntaxColoring SyntaxColoring added api Affects the `api` project docs papi-v2 Python API V2 labels Feb 15, 2024
@SyntaxColoring SyntaxColoring requested a review from a team as a code owner February 15, 2024 16:40
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcd312d) 67.78% compared to head (c4a8045) 67.78%.
Report is 3 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14500      +/-   ##
==========================================
- Coverage   67.78%   67.78%   -0.01%     
==========================================
  Files        2517     2517              
  Lines       72044    72043       -1     
  Branches     9274     9274              
==========================================
- Hits        48838    48837       -1     
  Misses      20991    20991              
  Partials     2215     2215              
Flag Coverage Δ
app 64.64% <ø> (ø)
components 48.90% <ø> (ø)
g-code-testing 92.43% <ø> (ø)
labware-library 41.11% <ø> (ø)
protocol-designer 37.93% <ø> (ø)
react-api-client 66.38% <ø> (ø)
step-generation 86.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/src/opentrons/protocol_api/protocol_context.py 92.74% <ø> (-0.06%) ⬇️

Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying this. Part of me wants for this to be a .. versionchanged message, but I think a proper explanation would be too long in that format. So the .. note is better.

api/src/opentrons/protocol_api/protocol_context.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jwwojak jwwojak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to Ed's comment. Otherwise, LGTM.

:shipit:

Co-authored-by: Ed Cormany <[email protected]>
@SyntaxColoring SyntaxColoring merged commit 678d5c1 into edge Feb 15, 2024
15 checks passed
@SyntaxColoring SyntaxColoring deleted the pause_docs_fix branch February 15, 2024 18:41
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project docs papi-v2 Python API V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants