-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(api): Update reference docs for ProtocolContext.pause()
#14500
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14500 +/- ##
==========================================
- Coverage 67.78% 67.78% -0.01%
==========================================
Files 2517 2517
Lines 72044 72043 -1
Branches 9274 9274
==========================================
- Hits 48838 48837 -1
Misses 20991 20991
Partials 2215 2215
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying this. Part of me wants for this to be a .. versionchanged
message, but I think a proper explanation would be too long in that format. So the .. note
is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 to Ed's comment. Otherwise, LGTM.
Co-authored-by: Ed Cormany <[email protected]>
Co-authored-by: Ed Cormany <[email protected]>
Changelog
ProtocolContext.pause()
has confusing (RESC-165, RESC-201) behavior on Python Protocol API version 2.13 and below. This was documented, but we didn't document that it's fixed in Protocol API v2.14. Do that here.Review requests
None in particular.
Risk assessment
No risk.