Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app-shell, app-shell-odd): Fix intermittently dropped notifications #14477

Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix(app-shell, app-shell-odd): Fix intermittently dropped notifications #14477

merged 2 commits into from
Feb 13, 2024

Commits on Feb 12, 2024

  1. fix(app-shell, app-shell-odd): fix intermittently dropped notifications 

    Because subscription logic is directly tied to the component lifecycle, it is possible for a
component to trigger an unsubscribe event on dismount while a new component mounts and triggers a
subscribe event. For the connection store and MQTT to reflect correct topic subscriptions, do not
unsubscribe and close connections before newly mounted components have had time to update the
connection store.
    @mjhuff
    mjhuff committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    7073a1c View commit details
    Browse the repository at this point in the history

  2. up the timeout

    @mjhuff
    mjhuff committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    f204d01 View commit details
    Browse the repository at this point in the history