-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): disable external links from opening in ODD #14472
feat(app): disable external links from opening in ODD #14472
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14472 +/- ##
=======================================================
+ Coverage 67.78% 67.80% +0.01%
=======================================================
Files 2519 2519
Lines 72011 72043 +32
Branches 9263 9279 +16
=======================================================
+ Hits 48812 48846 +34
+ Misses 20991 20988 -3
- Partials 2208 2209 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing
Once fix js-checks, this should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with passing CI!
oops thanks for fixing the linting issue @koji ! |
Overview
This PR disables the browser layer from opening up new windows on the ODD.
closes RQA-2318
Changelog
Review requests
Open up release notes on the ODD and press one of the links. Nothing should happen.
Risk assessment
Low