Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): update useIsRobot busy hook to check for firmware update #14457

Merged

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Feb 8, 2024

closes RQA-2293

Overview

Query subsystem updates in useIsRobotBusy hook to check for in-progress firmware updates as discovered in erroneously enabled robot overflow menu during firmware update.

Test Plan

  • launch firmware update from ODD
  • observe that robot overflow menu is disabled

Changelog

  • add subsystem update query to usIsRobotBusy
  • audit uses of useIsRobotBusy to ensure we aren't accidentally disabling other areas of the app during a firmware update

Review Requests

The polling interval in useIsRobotBusy is set to 30s. This was previously only used in the hook conditionally with useNotifyCurrentMaintenanceRun if we are using polling instead of notifications. Is this long of a polling interval not useful with useCurrentAllSubsystemUpdatesQuery?

Risk assessment

medium

Query subsystem updates in useIsRobotBusy hook to check for in-progress firmware updates as
discovered in erroniously enabled robot overflow menu during firmwre update.
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (17963c0) 67.77% compared to head (65446d4) 67.77%.
Report is 1 commits behind head on chore_release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14457      +/-   ##
=======================================================
- Coverage                67.77%   67.77%   -0.01%     
=======================================================
  Files                     2518     2518              
  Lines                    71968    72049      +81     
  Branches                  9244     9290      +46     
=======================================================
+ Hits                     48777    48831      +54     
- Misses                   20989    21005      +16     
- Partials                  2202     2213      +11     
Flag Coverage Δ
app 64.59% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/organisms/Devices/hooks/useIsRobotBusy.ts 77.77% <66.66%> (-2.23%) ⬇️

... and 2 files with indirect coverage changes

@ncdiehl11 ncdiehl11 marked this pull request as ready for review February 8, 2024 20:47
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner February 8, 2024 20:47
Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me!

@ncdiehl11 ncdiehl11 merged commit a3428ad into chore_release-7.2.0 Feb 9, 2024
21 of 22 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-check-fw-update-robot-is-busy branch February 9, 2024 16:06
TamarZanzouri pushed a commit that referenced this pull request Feb 16, 2024
…14457)

* fix(app): update useIsRobot busy hook to check for firmware update

closes RQA-2293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants