Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): Fix improper transitioning run status in protocol runs #14454

Closed
wants to merge 7 commits into from
Closed

fix(app): Fix improper transitioning run status in protocol runs #14454

wants to merge 7 commits into from

Commits on Feb 7, 2024

  1. fix(app-testing): snapshot failure capture (#14439) 

    addition of ignoreTipConfiguration flags
    @github-actions
    github-actions[bot] authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    00ccc2c View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. don't subscribe to null runs

    @mjhuff
    mjhuff committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    5314a7a View commit details
    Browse the repository at this point in the history

  2. add/shuffle logic for sanity check reasons

    @mjhuff
    mjhuff committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    eac27e1 View commit details
    Browse the repository at this point in the history

  3. fix(app): fix non polling notify hooks not always refetching data app… 

    …ropriately

Instead of checking the refetchInterval property to see if a notification refetch should occur, we
should check if staleTime is infinity. This accurately captures the refetchHTTP behavior that we
actually want.
    @mjhuff
    mjhuff committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f1912ea View commit details
    Browse the repository at this point in the history

  4. fix(app): fix infinite cancelling run state when run status is idle->… 

    …stop-requested
    @mjhuff
    mjhuff committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d6f9b22 View commit details
    Browse the repository at this point in the history

  5. delete unused import

    @mjhuff
    mjhuff committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    208575f View commit details
    Browse the repository at this point in the history

  6. update docstring

    @mjhuff
    mjhuff committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    91520f5 View commit details
    Browse the repository at this point in the history