Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(monorepo): migrate frontend bundling from webpack to vite #14405

Merged
merged 365 commits into from
Mar 8, 2024

Conversation

shlokamin
Copy link
Member

@shlokamin shlokamin commented Feb 1, 2024

Overview

This PR:

  • migrates monorepo frontend bundling from webpack to vite
  • migrates all jest tests to vitest
  • updates storybook

Test Plan

Because this PR is so massive, the best way to test this is to smoke test:

  • PD
  • The desktop app
  • The ODD app (on a Flex)
  • Labware Library
  • Components library (storybook)

Changelog

  • Adopt vite as the frontend bundler
  • Adopt vitest as the frontend testing library

Review requests

This PR is massive so it's not going to be a good use of time to go through every file change. Important ones to review though:

  • vitest config
  • vite config in each project
  • package json in each project
  • electron bundler config
  • makefiles in each project

Risk assessment

on a scale from 1-10 probably like a 47

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.47%. Comparing base (d6d9416) to head (16b00d2).
Report is 7 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14405      +/-   ##
==========================================
- Coverage   67.50%   67.47%   -0.03%     
==========================================
  Files        2514     2484      -30     
  Lines       72376    71319    -1057     
  Branches     9317     9084     -233     
==========================================
- Hits        48857    48125     -732     
+ Misses      21314    21039     -275     
+ Partials     2205     2155      -50     
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)
hardware 57.22% <ø> (ø)
hardware-testing ∅ <ø> (∅)
shared-data 75.94% <ø> (+0.64%) ⬆️
system-server 96.04% <ø> (ø)
update-server 50.56% <ø> (ø)
usb-bridge 76.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app-shell-odd/src/config/index.ts 9.09% <ø> (+0.39%) ⬆️
app-shell-odd/src/config/migrate.ts 89.74% <ø> (ø)
app-shell-odd/src/config/update.ts 100.00% <ø> (ø)
app-shell-odd/src/discovery.ts 95.91% <ø> (ø)
app-shell-odd/src/http.ts 23.07% <ø> (ø)
app-shell-odd/src/main.ts 0.00% <ø> (ø)
app-shell-odd/src/preload.ts 0.00% <ø> (ø)
app-shell-odd/src/restart.ts 0.00% <ø> (ø)
app-shell-odd/src/system-update/index.ts 0.00% <ø> (ø)
app-shell-odd/src/ui.ts 0.00% <ø> (ø)
... and 61 more

... and 35 files with indirect coverage changes

@shlokamin shlokamin force-pushed the protocol_designer-migrate-webpack-to-vite branch from 57c9e95 to dab10da Compare February 23, 2024 14:59
shlokamin and others added 28 commits February 26, 2024 10:27
…m:Opentrons/opentrons into protocol_designer-migrate-webpack-to-vite
@shlokamin shlokamin marked this pull request as ready for review March 8, 2024 16:35
@shlokamin shlokamin requested review from a team as code owners March 8, 2024 16:35
@shlokamin shlokamin requested a review from a team March 8, 2024 16:35
@shlokamin shlokamin requested a review from a team as a code owner March 8, 2024 16:35
@shlokamin shlokamin requested review from b-cooper and removed request for a team March 8, 2024 16:35
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@shlokamin shlokamin requested a review from sfoster1 March 8, 2024 16:54
@shlokamin shlokamin merged commit 2bab955 into edge Mar 8, 2024
65 of 67 checks passed
@koji koji deleted the protocol_designer-migrate-webpack-to-vite branch April 17, 2024 19:02
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
migrate frontend bundler from webpack to vite

Co-authored-by: Jamey Huffnagle <[email protected]>
Co-authored-by: Brian Cooper <[email protected]>
Co-authored-by: koji <[email protected]>
Co-authored-by: Jethary <[email protected]>
Co-authored-by: ncdiehl11 <[email protected]>
Co-authored-by: smb2268 <[email protected]>
Co-authored-by: Brent Hagen <[email protected]>
Carlos-fernandez pushed a commit that referenced this pull request Jun 3, 2024
migrate frontend bundler from webpack to vite

Co-authored-by: Jamey Huffnagle <[email protected]>
Co-authored-by: Brian Cooper <[email protected]>
Co-authored-by: koji <[email protected]>
Co-authored-by: Jethary <[email protected]>
Co-authored-by: ncdiehl11 <[email protected]>
Co-authored-by: smb2268 <[email protected]>
Co-authored-by: Brent Hagen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants