Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): refactor show labware offset snippets #14367

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Jan 28, 2024

Overview

Add ShowLabwareOffsetSnippets component and its test.

Close RAUT-938 partially

Test Plan

Changelog

  • add ShowLabwareOffsetSnippets component and its test
  • update AdvancedSettings and its test

Review requests

Risk assessment

low

@koji koji requested a review from a team January 28, 2024 13:56
@koji koji marked this pull request as ready for review January 28, 2024 13:56
@koji koji requested a review from a team as a code owner January 28, 2024 13:56
@koji koji requested review from shlokamin and removed request for a team and shlokamin January 28, 2024 13:56
Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (404f66b) 67.89% compared to head (3663ba7) 67.89%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #14367   +/-   ##
=======================================
  Coverage   67.89%   67.89%           
=======================================
  Files        2511     2512    +1     
  Lines       71884    71887    +3     
  Branches     9164     9164           
=======================================
+ Hits        48807    48811    +4     
+ Misses      20946    20945    -1     
  Partials     2131     2131           
Flag Coverage Δ
app 64.84% <100.00%> (+0.01%) ⬆️
components 48.85% <ø> (ø)
protocol-designer 35.30% <ø> (ø)
react-api-client 66.16% <ø> (ø)
step-generation 86.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...sms/AdvancedSettings/ShowLabwareOffsetSnippets.tsx 100.00% <100.00%> (ø)
app/src/pages/AppSettings/AdvancedSettings.tsx 72.22% <ø> (+0.79%) ⬆️

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨

@koji koji merged commit 0c2fbf5 into edge Jan 30, 2024
36 checks passed
@koji koji deleted the app_refactor-ShowLabwareOffsetSnippets branch January 30, 2024 04:39
ncdiehl11 pushed a commit that referenced this pull request Feb 1, 2024
* refactor(app): refactor ShowLabwareOffsetSnippets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants