Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix various drop tip wizard issues #14207

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Dec 14, 2023

Closes RQA-2083, RQA-2094, RQA-2066, RQA-2068, RQA-2024, RQA-2100

Overview

This PR is a general second-pass of the drop tip wizard. There's a good bit refactoring, but in terms of functional changes:

  • The wizard doesn't render BeforeBeginning until the maintenance run has been successfully created - renders a spinner now. This prevents some bugs and is better UX.
  • Exiting the drop tip wizard now renders a spinner and exits properly.
  • The home command occurs in a predictable spot - no more instantly homing after completing blowout.
  • Use moveToAddressableArea instead of moveRelative to prevent unexpected pipette movements (you CANNOT move to a slot with a moveable trash or waste chute loaded -- this is a known issue and currently being fixed).
  • Fixes an issue where an unreachable step could be hit.
  • More error messaging!

Test Plan

  • Run through the flows on OT-2 and Flex and make sure it works properly!
  • NOTE: you CANNOT move to a slot with a moveable trash or waste chute loaded -- this is a known issue and currently being addressed by @brenthagen

Changelog

  • Fixes several issues related to the drop tip wizard concerning exiting, error messaging, and missing loading spinners.

Review requests

  • Test on a physical robot. Do the desktop and ODD flows. Test on OT-2 as well.

Risk assessment

medium

@mjhuff mjhuff requested review from b-cooper, brenthagen, ncdiehl11 and a team December 14, 2023 20:42
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #14207 (61319b9) into chore_release-7.1.0 (76bf6b8) will decrease coverage by 0.03%.
Report is 9 commits behind head on chore_release-7.1.0.
The diff coverage is 18.00%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14207      +/-   ##
=======================================================
- Coverage                70.42%   70.40%   -0.03%     
=======================================================
  Files                     1636     2512     +876     
  Lines                    54504    71502   +16998     
  Branches                  4028     9106    +5078     
=======================================================
+ Hits                     38384    50340   +11956     
- Misses                   15420    18942    +3522     
- Partials                   700     2220    +1520     
Flag Coverage Δ
app 67.50% <18.00%> (+28.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pp/src/organisms/DropTipWizard/BeforeBeginning.tsx 45.83% <50.00%> (ø)
app/src/organisms/DropTipWizard/ChooseLocation.tsx 18.18% <0.00%> (ø)
...p/src/organisms/DropTipWizard/ExitConfirmation.tsx 0.00% <0.00%> (ø)
app/src/organisms/DropTipWizard/Success.tsx 14.28% <0.00%> (ø)
app/src/organisms/DropTipWizard/JogToPosition.tsx 9.09% <0.00%> (ø)
app/src/organisms/DropTipWizard/index.tsx 31.81% <26.66%> (ø)

... and 870 files with indirect coverage changes

@mjhuff mjhuff changed the base branch from edge to chore_release-7.1.0 December 14, 2023 20:49
@mjhuff mjhuff marked this pull request as ready for review December 14, 2023 22:15
@mjhuff mjhuff requested a review from a team as a code owner December 14, 2023 22:15
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with known issue!

@sfoster1 sfoster1 merged commit a7d1187 into chore_release-7.1.0 Dec 14, 2023
21 of 22 checks passed
@sfoster1 sfoster1 deleted the app_drop-tip-wizard-fixes branch December 14, 2023 22:19
ncdiehl11 pushed a commit that referenced this pull request Dec 20, 2023
This PR is a general second-pass of the drop tip wizard. There's a good bit refactoring, but in terms of functional changes:

  - The wizard doesn't render BeforeBeginning until the maintenance run has been successfully created - renders a spinner now. This prevents some bugs and is better UX.
  - Exiting the drop tip wizard now renders a spinner and exits properly.
  - The home command occurs in a predictable spot - no more instantly homing after completing blowout.
  - Use moveToAddressableArea instead of moveRelative to prevent unexpected pipette movements (you CANNOT move to a slot with a moveable trash or waste chute loaded -- this is a known issue and currently being fixed).
  - Fixes an issue where an unreachable step could be hit.
  - More error messaging!
NOTE: you CANNOT move to a slot with a moveable trash or waste chute loaded -- this is a known issue and currently being addressed separately.

Closes RQA-2083, RQA-2094, RQA-2066, RQA-2068, RQA-2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants