-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): fix various drop tip wizard issues #14207
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14207 +/- ##
=======================================================
- Coverage 70.42% 70.40% -0.03%
=======================================================
Files 1636 2512 +876
Lines 54504 71502 +16998
Branches 4028 9106 +5078
=======================================================
+ Hits 38384 50340 +11956
- Misses 15420 18942 +3522
- Partials 700 2220 +1520
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with known issue!
This PR is a general second-pass of the drop tip wizard. There's a good bit refactoring, but in terms of functional changes: - The wizard doesn't render BeforeBeginning until the maintenance run has been successfully created - renders a spinner now. This prevents some bugs and is better UX. - Exiting the drop tip wizard now renders a spinner and exits properly. - The home command occurs in a predictable spot - no more instantly homing after completing blowout. - Use moveToAddressableArea instead of moveRelative to prevent unexpected pipette movements (you CANNOT move to a slot with a moveable trash or waste chute loaded -- this is a known issue and currently being fixed). - Fixes an issue where an unreachable step could be hit. - More error messaging! NOTE: you CANNOT move to a slot with a moveable trash or waste chute loaded -- this is a known issue and currently being addressed separately. Closes RQA-2083, RQA-2094, RQA-2066, RQA-2068, RQA-2024
Closes RQA-2083, RQA-2094, RQA-2066, RQA-2068, RQA-2024, RQA-2100
Overview
This PR is a general second-pass of the drop tip wizard. There's a good bit refactoring, but in terms of functional changes:
Test Plan
Changelog
Review requests
Risk assessment
medium