fix(api): display name in deck conflict error message #14185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In #14173 I didn't realize that
labware_view.get_display_name
provided only user-specified display name. So deck conflict error messages could say "None should be on an Opentrons adapter.." if no custom display name was specified for the tiprack.This PR fixes that mistake.
Test Plan
The protocol attached in #14173 should now show errors with correct display names.
Changelog
labware_view.get_display_name
toget_user_specified_display_name
labware_view.get_display_name
that returns the user specified display name if present, else returns the display name from labware definitionReview requests
Risk assessment
Low. Bug fix