test(api): Add integration tests for load conflicts with the fixed trash #14151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14151 +/- ##
====================================================
Coverage 70.41% 70.41%
====================================================
Files 2483 2483
Lines 70339 70339
Branches 8778 8778
====================================================
Hits 49531 49531
Misses 18653 18653
Partials 2155 2155
Flags with carried forward coverage won't be shown. Click here to find out more. |
CaseyBatten
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add tests to cover RQA-2015 / PR #14136.
Test Plan
On a local branch, I've reverted PR #14136 and confirmed that these tests catch RQA-2015.
Changelog
Test that you can generally load things into slot 12 when, and only when, your protocol will not have a fixed trash.
Review requests
Take a look at the test parametrizations and make sure they make sense. The OT-2+APIv2.16 case in particular is a bit weird, arguably an architectural bug. I haven't ticketed it, but I could if you think we should actually plan to fix it.
Risk assessment
No risk.