Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): check firmware update status in instrument cards #14110

Merged
merged 16 commits into from
Dec 13, 2023

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Dec 6, 2023

Overview

Improve accuracy of instrument status available on instrument card and fix bug where firmware update modal was never popping up on ODD

Test Plan

Without going through an attachment flow, attach a pipette that will need a firmware update to a robot. See that the firmware update needed modal pops up on ODD. Initiate update via ODD and simultaneously watch the steps that occur on the corresponding instrument card via the desktop app. The card should show "Update in progress..." until about 5 seconds after the update is completed. Then, the instrument card should populate with the attached pipette

Changelog

  1. Add migration from stale /dashboard config value to null - this was preventing the firmware update modal from popping up on ODD because we rely on a null value to tell us that the unboxing flow is not in progress
  2. Update poll for subsystem endpoint to continue until after the status of an update is done. Use that same value to determine when to start showing the attached instrument card, as this should give the /instruments endpoint enough time to reliably report what is attached

Review requests

Look over changes (especially the config migration - did I cover everything?) & run through the test plan if you can

Risk assessment

Low

app/src/organisms/GripperCard/index.tsx Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #14110 (4b86e9c) into chore_release-7.1.0 (06488fe) will decrease coverage by 0.16%.
Report is 68 commits behind head on chore_release-7.1.0.
The diff coverage is 64.91%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14110      +/-   ##
=======================================================
- Coverage                70.47%   70.31%   -0.16%     
=======================================================
  Files                     2512     2512              
  Lines                    71196    72299    +1103     
  Branches                  8958     9475     +517     
=======================================================
+ Hits                     50173    50838     +665     
- Misses                   18832    19155     +323     
- Partials                  2191     2306     +115     
Flag Coverage Δ
app 67.16% <64.91%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/organisms/FirmwareUpdateModal/index.tsx 87.50% <100.00%> (ø)
app/src/redux/config/selectors.ts 95.00% <100.00%> (ø)
app-shell-odd/src/config/migrate.ts 89.74% <66.66%> (-1.93%) ⬇️
app-shell/src/config/migrate.ts 94.73% <66.66%> (-1.16%) ⬇️
...rganisms/FirmwareUpdateModal/UpdateNeededModal.tsx 82.35% <88.88%> (+2.35%) ⬆️
...sms/FirmwareUpdateModal/FirmwareUpdateTakeover.tsx 89.28% <75.00%> (-10.72%) ⬇️
...ganisms/FirmwareUpdateModal/UpdateResultsModal.tsx 72.72% <62.50%> (-2.28%) ⬇️
app/src/organisms/GripperCard/index.tsx 82.05% <50.00%> (-11.50%) ⬇️
app/src/organisms/Devices/PipetteCard/index.tsx 55.84% <40.00%> (-4.16%) ⬇️

... and 39 files with indirect coverage changes

@koji
Copy link
Contributor

koji commented Dec 6, 2023

I think when we update config, we will need to update app-shell and app-shell-odd.

@smb2268 smb2268 requested review from sfoster1 and koji December 6, 2023 20:08
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed the test plan and it worked as expected!
The changes look good to me.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@smb2268 smb2268 merged commit 59c1042 into chore_release-7.1.0 Dec 13, 2023
21 of 22 checks passed
@smb2268 smb2268 deleted the app_subsystem-update-fix branch December 13, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants