-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): check firmware update status in instrument cards #14110
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14110 +/- ##
=======================================================
- Coverage 70.47% 70.31% -0.16%
=======================================================
Files 2512 2512
Lines 71196 72299 +1103
Branches 8958 9475 +517
=======================================================
+ Hits 50173 50838 +665
- Misses 18832 19155 +323
- Partials 2191 2306 +115
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I think when we update config, we will need to update |
app/src/organisms/FirmwareUpdateModal/FirmwareUpdateTakeover.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed the test plan and it worked as expected!
The changes look good to me.
14c15d6
to
4da87a8
Compare
4da87a8
to
4b86e9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Overview
Improve accuracy of instrument status available on instrument card and fix bug where firmware update modal was never popping up on ODD
Test Plan
Without going through an attachment flow, attach a pipette that will need a firmware update to a robot. See that the firmware update needed modal pops up on ODD. Initiate update via ODD and simultaneously watch the steps that occur on the corresponding instrument card via the desktop app. The card should show "Update in progress..." until about 5 seconds after the update is completed. Then, the instrument card should populate with the attached pipette
Changelog
/dashboard
config value tonull
- this was preventing the firmware update modal from popping up on ODD because we rely on anull
value to tell us that the unboxing flow is not in progressdone
. Use that same value to determine when to start showing the attached instrument card, as this should give the/instruments
endpoint enough time to reliably report what is attachedReview requests
Look over changes (especially the config migration - did I cover everything?) & run through the test plan if you can
Risk assessment
Low