docs(api): edit docstring for configure_nozzle_layout
#13997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecormany
added
docs
DO NOT MERGE
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #13997 +/- ##
====================================================
Coverage 70.46% 70.46%
====================================================
Files 2512 2512
Lines 71202 71202
Branches 8965 8965
====================================================
Hits 50169 50169
Misses 18841 18841
Partials 2192 2192
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ecormany
removed
the
DO NOT MERGE
|
Fact check is correct, description is correct, merge conflicts are now fixed |
| ``"A1"`` to have the pipette use its leftmost nozzles to pick up tips | ||
| *left-to-right* from a tip rack. Use ``"A12"`` to have the pipette use its | ||
| rightmost nozzles to pick up tips *right-to-left* from a tip rack. | ||
| :type start: str or ``None`` |
There was a problem hiding this comment.
I think we're missing the tip_racks parameter in this list? Unless the diff is being weird.
There was a problem hiding this comment.
Oh yeah, because it just got merged an hour ago! 😅 I will get the stub that @sanni-t wrote back in, and follow up with her on anything more we want to say about it or the new active_channels property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update the docstring for
configure_nozzle_layout, first added in #13838. Goals for this PR:Test Plan
Reference entry in sandbox
Changelog
front_rightparameterReview requests
Make sure I've characterized features properly. I haven't been able to simulate protocols using this function yet, much less test them on hardware.
Fact check this claim:
If you try to perform partial tip pickup on a tip rack that is in an adapter, the API will raise an error.Check that I didn't mess anything up when rebasing and resolving conflicts.
Risk assessment
low, docstrings + a comment hanging off the bottom of the docstring (can't comment within the string)