Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): only send moves to moving axes, unless specified otherwise #13933

Merged

Conversation

ahiuchingau
Copy link
Contributor

Overview

This allows us to keep certain axes disengaged while we command other axes to move.

Instead of sending moves to all present motor nodes all the time, regardless of
whether they actually need to move or not, we are only sending the move requests to
the axes that are defined in the moves.

Most of the time we're ordering a mount to move (see various move methods in ot3api).
This guarantees that the axes pertaining to that mount (X, Y, and Z) will be receiving the moves
together but the other idle mounts will be left alone.

@ahiuchingau ahiuchingau requested a review from a team as a code owner November 6, 2023 23:42
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #13933 (b72e6ad) into edge (71c168f) will not change coverage.
Report is 15 commits behind head on edge.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #13933   +/-   ##
=======================================
  Coverage   70.84%   70.84%           
=======================================
  Files        2504     2504           
  Lines       70441    70441           
  Branches     8607     8607           
=======================================
  Hits        49902    49902           
  Misses      18441    18441           
  Partials     2098     2098           
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...entrons/hardware_control/backends/ot3controller.py 67.85% <ø> (ø)

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is really nice, thanks!

@ahiuchingau ahiuchingau merged commit 07d518f into edge Nov 7, 2023
25 checks passed
@ahiuchingau ahiuchingau deleted the RQA-1870-pvt-1-abr-12-gripper-drops-when-calibrating-pipette branch November 7, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants