-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(app, app-shell, app-shell-odd): update electron version from 21 to 27 #13602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji
changed the title
chore(app, app-shell): update electron version from 21 to 26
chore(app, app-shell, app-shell-odd): update electron version from 21 to 26
Sep 20, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13602 +/- ##
==========================================
- Coverage 70.47% 70.12% -0.35%
==========================================
Files 2480 2510 +30
Lines 70306 72802 +2496
Branches 8718 9657 +939
==========================================
+ Hits 49548 51054 +1506
- Misses 18606 19413 +807
- Partials 2152 2335 +183
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
koji
changed the title
chore(app, app-shell, app-shell-odd): update electron version from 21 to 26
chore(app, app-shell, app-shell-odd): update electron version from 21 to 27
Nov 29, 2023
notenode v21 has an issue on |
Co-authored-by: wweiye <[email protected]>
…s to npm (#14077) In order to support a single source of truth for applications outside of the monorepo (read: "Protocol Library") that rely on fundamental components and geometries within the mono repo, add tag based deploy actions that publish bundled artifacts to NPM.
* Starting Labware and Wells section only Refactor code elements in the docstrings to use the monospace font. Multiple instances of authors using a single ` ` to note a code snipped, but this requires `` `` instead. * More docstrings revisions * Misspelled word in a comment * Re-add anchor to robot_position.rst Was removed accidentally. Used in other locations. This restores anchor links. * Forgot to run black All done! ✨ 🍰 ✨ 1 file reformatted. Removed trailing space after a comma. * Update api/src/opentrons/protocol_api/labware.py Co-authored-by: Ed Cormany <[email protected]> * Update api/src/opentrons/protocol_api/labware.py Co-authored-by: Ed Cormany <[email protected]> * Update api/src/opentrons/protocol_api/labware.py Co-authored-by: Ed Cormany <[email protected]> * Update api/src/opentrons/protocol_api/labware.py Co-authored-by: Ed Cormany <[email protected]> * Link Wells and wells_by_name * Changes from reviewers * Fix ellipses --------- Co-authored-by: Ed Cormany <[email protected]>
Fix bug that was causing ci to attempt the publish step of every pr build
…14138) Updates the PD blow_out default values
* pass around mypy protocol instead of OT3API * Explicit parameterization of config types * Fix some tests with the protocol engine related to protocol changes * Added a `FlexInstrumentConfigurer` for flex-specific configuration extensions * Update test mocks to differentiate ot2/ot3 hardware * Modifed `get_robot_type` to be parameterized on some singleton class types for robot models * remove unnecessary TYPE_CHECKING import * Add tip presence protocol functions to satisfy edits to tip manager
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is an experimental branch to update Electron version from v21 to v26
There is a big issue in this branch which is
legacy OpenSSL provider
.There are a couple of approaches to solve that issue.
Right now, this branch is using option 1 since it's a very easy way to update Electron and run Desktop app.However, this shouldn't be a solution because of this, nodejs/Release#908.
Currently this branch is using option2 with node 18.16.1.
Therefore, probably option 3 would be a good solution for us. But, this can be controversial since the app&ui team has been thinking of switching module bundler(webpack) to vite or something else.
The goal of this branch would be to merge into
edge
in 2023.Current status
Additional tasks
Once this branch fixes errors on PD and LL, I will create a new branch from this to update the Electron version since v26's life will end on 2/27/2024.
Also we would need to update a couple of packages that are related to Electron such as context-menu and etc.
Test Plan
Changelog
Review requests
Risk assessment
mid