Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix ODD UI bugs #13455

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Conversation

koji
Copy link
Contributor

@koji koji commented Sep 1, 2023

Overview

This PR will fix some UI bugs in ODD app.
Close RAUT-654 and RQA-924

In terms of components that related to Network settings, the current implementation isn't good since there were design updates and components' structure change etc.
I will do refactoring to make all related components more readable and maintainable.

  • Network Settings layout issue in RobotSettings.

before

Screenshot 2023-08-31 at 5 18 19 PM
Screenshot 2023-08-31 at 5 27 48 PM
Screenshot 2023-08-31 at 6 07 01 PM

after

Also update input form padding to align with the latest design
Screenshot 2023-08-31 at 6 11 02 PM
Screenshot 2023-08-31 at 6 11 09 PM
Screenshot 2023-08-31 at 6 11 21 PM

  • Text wrapping issue in Modals

before

Screenshot 2023-09-01 at 1 23 39 PM
Screenshot 2023-09-01 at 1 29 00 PM

after

Screenshot 2023-09-01 at 2 55 21 PM
Screenshot 2023-09-01 at 2 58 00 PM

  • Remove Temp ODD menu from Choose network type screen

  • Fix overflow menu's behavior in navigation when tapping home gantry

  • Update software keyboard (key-height and margin-bottom)

Test Plan

Changelog

Review requests

Risk assessment

low

@koji koji changed the base branch from edge to chore_release-7.0.0 September 1, 2023 19:39
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #13455 (ffd70bc) into chore_release-7.0.0 (a400189) will decrease coverage by 12.58%.
Report is 16 commits behind head on chore_release-7.0.0.
The diff coverage is n/a.

❗ Current head ffd70bc differs from pull request most recent head b4d09a2. Consider uploading reports for the commit b4d09a2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           chore_release-7.0.0   #13455       +/-   ##
========================================================
- Coverage                71.38%   58.81%   -12.58%     
========================================================
  Files                     2434     1098     -1336     
  Lines                    67905    27548    -40357     
  Branches                  7880     3460     -4420     
========================================================
- Hits                     48477    16202    -32275     
+ Misses                   17586    10813     -6773     
+ Partials                  1842      533     -1309     
Flag Coverage Δ
api ?
app 41.32% <ø> (-27.75%) ⬇️
ot3-gravimetric-test ?
robot-server ?
update-server ?
usb-bridge ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1353 files with indirect coverage changes

@koji koji requested a review from a team September 1, 2023 19:44
@koji koji marked this pull request as ready for review September 1, 2023 20:36
@koji koji requested a review from a team as a code owner September 1, 2023 20:36
@koji koji requested review from jerader and removed request for a team September 1, 2023 20:36
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦁

@@ -93,15 +90,6 @@ export function NetworkSetupMenu(): JSX.Element {
/>
))}
</Flex>
<Flex
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

@koji koji merged commit 966f06a into chore_release-7.0.0 Sep 1, 2023
18 checks passed
mjhuff pushed a commit that referenced this pull request Sep 5, 2023
* fix(app): fix various odd ui issues
TamarZanzouri pushed a commit that referenced this pull request Sep 13, 2023
* fix(app): fix various odd ui issues
@koji koji deleted the fix_wifi-settings-layout-issue branch July 4, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants