-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): fix ODD UI bugs #13455
fix(app): fix ODD UI bugs #13455
Conversation
fix the following ui issues close RAUT-
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13455 +/- ##
========================================================
- Coverage 71.38% 58.81% -12.58%
========================================================
Files 2434 1098 -1336
Lines 67905 27548 -40357
Branches 7880 3460 -4420
========================================================
- Hits 48477 16202 -32275
+ Misses 17586 10813 -6773
+ Partials 1842 533 -1309
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦁
@@ -93,15 +90,6 @@ export function NetworkSetupMenu(): JSX.Element { | |||
/> | |||
))} | |||
</Flex> | |||
<Flex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔪
* fix(app): fix various odd ui issues
* fix(app): fix various odd ui issues
Overview
This PR will fix some UI bugs in ODD app.
Close RAUT-654 and RQA-924
In terms of components that related to Network settings, the current implementation isn't good since there were design updates and components' structure change etc.
I will do refactoring to make all related components more readable and maintainable.
before
after
Also update input form padding to align with the latest design
before
after
Remove Temp ODD menu from Choose network type screen
Fix overflow menu's behavior in navigation when tapping home gantry
Update software keyboard (key-height and margin-bottom)
Test Plan
Changelog
Review requests
Risk assessment
low