Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(server-utils): Add unit tests for server_utils.sql_utils #13453

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Sep 1, 2023

Overview

Add unit tests to cover the new server_utils.sql_utils module, which I added in #13424. We need these to detect the obscure bug that that PR fixed.

Closes RSS-331.

Review requests

Is this readable and understandable?

Risk assessment

No risk.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner September 1, 2023 18:49
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #13453 (81de1e0) into chore_release-7.0.0 (32e90d7) will increase coverage by 24.64%.
Report is 21 commits behind head on chore_release-7.0.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           chore_release-7.0.0   #13453       +/-   ##
========================================================
+ Coverage                71.38%   96.02%   +24.64%     
========================================================
  Files                     2437       33     -2404     
  Lines                    67933      428    -67505     
  Branches                  7886        0     -7886     
========================================================
- Hits                     48496      411    -48085     
+ Misses                   17594       17    -17577     
+ Partials                  1843        0     -1843     
Flag Coverage Δ
api ?
app ?
components ?
g-code-testing ?
hardware ?
hardware-testing ?
labware-library ?
notify-server ?
ot3-gravimetric-test ?
protocol-designer ?
react-api-client ?
robot-server ?
shared-data ?
step-generation ?
system-server 96.02% <ø> (ø)
update-server ?
usb-bridge ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2404 files with indirect coverage changes

@SyntaxColoring SyntaxColoring requested a review from a team September 13, 2023 15:13
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love new tests

@SyntaxColoring SyntaxColoring merged commit da83a9f into chore_release-7.0.0 Sep 15, 2023
12 checks passed
@SyntaxColoring SyntaxColoring deleted the tests_for_sql_utils branch September 15, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants