-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(engine): fix calculation for labware height on modules #13364
fix(engine): fix calculation for labware height on modules #13364
Conversation
Codecov Report
@@ Coverage Diff @@
## chore_release-7.0.0 #13364 +/- ##
=======================================================
- Coverage 71.67% 63.96% -7.71%
=======================================================
Files 2427 1970 -457
Lines 67641 43929 -23712
Branches 7807 7771 -36
=======================================================
- Hits 48479 28100 -20379
+ Misses 17335 14002 -3333
Partials 1827 1827
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to merge, given the test approval. Thanks!
I am confused by the code, though. One docstring request that might help.
Overview
I had forgotten to account for stacking overlap during calculation of the grip point when moving labware from/ to modules. This PR fixes that and adds a test to check for it.
Test Plan
Check that the gripping point of the same labware is same no matter if it's being moved to/ from:
Changelog
Review requests
Risk assessment
None if done correctly.