fix(app): fix error boundary icon #13201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current error boundary uses a wrong icon. This PR fixes that RQA-1168
Codecov Report
@@ Coverage Diff @@
## edge #13201 +/- ##
=======================================
Coverage 72.55% 72.55%
=======================================
Files 2398 2398
Lines 66084 66084
Branches 7368 7368
=======================================
Hits 47950 47950
Misses 16370 16370
Partials 1764 1764
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The current error boundary uses a wrong icon. This PR fixes that.
Also fix a potential bug in ProtocolDashboard
design
https://www.figma.com/file/AoTLAYuWawlaWItB1umOjr/Release%3A-Opentrons-Flex-Touchscreen?type=design&node-id=17641-406642&mode=design&t=2z80gpYH2pGdrxGB-0
close RQA-1168
Test Plan
Changelog
Review requests
Risk assessment