refactor(api): clean up labware movement error strings #13198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
approved these changes
Jul 31, 2023
| @@ -230,7 +230,7 @@ def ensure_valid_gripper_location( | |||
| location, (DeckSlotLocation, ModuleLocation, OnLabwareLocation) | |||
| ): | |||
| raise LabwareMovementNotAllowedError( | |||
| "Off-deck labware movements are not supported using the gripper." | |||
| "Cannot move labware off-deck using the gripper." | |||
There was a problem hiding this comment.
This string is used when the source location is off-deck, as well.
"Cannot move labware to or from off-deck using the gripper"? :\
There was a problem hiding this comment.
I kinda just discovered off-deck -> on-deck movements today 😅
Going with Cannot perform off-deck labware movements with the gripper.
Codecov Report
@@ Coverage Diff @@
## edge #13198 +/- ##
=======================================
Coverage 72.55% 72.55%
=======================================
Files 2398 2398
Lines 66084 66084
Branches 7368 7368
=======================================
Hits 47950 47950
Misses 16370 16370
Partials 1764 1764
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Small PR to clean up some user-facing error copy for labware movement.
Test Plan
Read words. Words good?
Changelog
Review requests
The only edits in this PR are within strings, but they are code, not docs. Is there anything preventing us from making these changes, and is
edgethe right target branch?Risk assessment
low.