Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): reduce unused mount currents with 96 #13181

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

sfoster1
Copy link
Member

This will make the hold and run currents for the unused right mount be much lower when the 96 is attached.

@sfoster1 sfoster1 requested a review from a team as a code owner July 27, 2023 17:50
@sfoster1 sfoster1 requested a review from a team July 27, 2023 17:50
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #13181 (928b2d5) into internal-release_0.14.0 (9f29c9d) will increase coverage by 0.06%.
Report is 4 commits behind head on internal-release_0.14.0.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                     @@
##           internal-release_0.14.0   #13181      +/-   ##
===========================================================
+ Coverage                    72.53%   72.59%   +0.06%     
===========================================================
  Files                         2394     2372      -22     
  Lines                        66062    65306     -756     
  Branches                      7342     7202     -140     
===========================================================
- Hits                         47915    47408     -507     
+ Misses                       16401    16153     -248     
+ Partials                      1746     1745       -1     
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/opentrons/hardware_control/backends/ot3utils.py 94.33% <ø> (-0.21%) ⬇️
api/src/opentrons/hardware_control/types.py 96.62% <ø> (-0.03%) ⬇️

... and 57 files with indirect coverage changes

Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfoster1 sfoster1 changed the base branch from internal-release_0.14.0 to edge July 27, 2023 19:43
@sfoster1 sfoster1 requested review from a team as code owners July 27, 2023 19:43
@sfoster1 sfoster1 requested review from TamarZanzouri and removed request for a team July 27, 2023 19:43
This will make the hold and run currents for the unused right mount be
much lower when the 96 is attached.
@sfoster1 sfoster1 merged commit 2ac1ab6 into edge Jul 27, 2023
22 of 23 checks passed
@sfoster1 sfoster1 deleted the drop-unused-head-currents branch July 27, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants