Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer, components): 7.0 candidate a bug fixes #13179

Merged
merged 17 commits into from
Aug 1, 2023

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jul 27, 2023

closes RQA-1080, RQA-1125, RQA-1102, RQA-1109, RAUT-589, RAUT-590, RQA-1110, RQA-1122, RQA-1100, RQA-1141, RQA-1148, RQA-1151

Overview

Addresses a handful of bugs

Test Plan

sandbox: https://sandbox.designer.opentrons.com/pd_bug-fixes-7.0/

On the sandbox build, test that each bug got addressed;

  1. add a magnetic module for OT-2 protocol, adding labware on top of it, make sure the correct labware is available and make sure the help link goes to the correct place (RAUT-589, RAUT-590)
  2. when editing the pipettes, make sure the arrow icon moves up and down when the dropdown is expanded or not (RQA-1080)
  3. make sure you can duplicate labware successfully on a flex and Ot-2 protocol (RQA-1125)
  4. add a labware to the deck and give it a verrry long nickname, make sure it truncates after ~3 lines (RQA-1102)
  5. add a liquid with a verrry long nickname, make sure it truncates properly both on the liquid tab and when you add the liquid to the labware (RQA-1109, RQA-1110)
  6. protocol name should truncate on design tab, but the subtitle to the right of it should not (RQA-1122)
  7. removal of the beta tag. See Linda's comment in RQA-1100
  8. touch_tip option should be disabled in advanced settings in the transfer step when you try to touch tip with a labware that doesn't support it. Hovering over it should show a tooltip explaining why its disabled (RQA-1148)
  9. the moveLabware step in the timeline should have the correct information shown (should display labware, new location, and if gripper is used or manual intervention is required) RQA-1151
  10. when you export a protocol with an unused pipette, the modal copy should be updated (RQA-1141)

Changelog

  • various components in protocol-designer directory - adding truncated strings, labware to recommended labware list, fixing a url, duplicate labware bug

Review requests

see test plan

Risk assessment

low

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #13179 (f4b6ab4) into edge (df3d742) will decrease coverage by 0.34%.
The diff coverage is 5.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13179      +/-   ##
==========================================
- Coverage   72.56%   72.23%   -0.34%     
==========================================
  Files        2393     2357      -36     
  Lines       66055    64000    -2055     
  Branches     7348     7370      +22     
==========================================
- Hits        47935    46229    -1706     
+ Misses      16360    16006     -354     
- Partials     1760     1765       +5     
Flag Coverage Δ
app 71.36% <ø> (ø)
components 63.08% <ø> (+0.03%) ⬆️
labware-library 49.17% <ø> (ø)
protocol-designer 47.13% <5.55%> (-0.24%) ⬇️
react-api-client 65.13% <ø> (ø)
step-generation 87.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
components/src/forms/Select.tsx 78.57% <ø> (+5.23%) ⬆️
...c/components/BatchEditForm/BatchEditMoveLiquid.tsx 23.52% <0.00%> (-8.48%) ⬇️
...mponents/DeckSetup/LabwareOverlays/LabwareName.tsx 33.33% <0.00%> (-4.17%) ⬇️
...-designer/src/components/IngredientsList/index.tsx 0.00% <0.00%> (ø)
...esigner/src/components/KnowledgeBaseLink/index.tsx 100.00% <ø> (ø)
...ts/LabwareSelectionModal/LabwareSelectionModal.tsx 40.65% <ø> (+0.44%) ⬆️
...l-designer/src/components/LiquidsSidebar/index.tsx 0.00% <0.00%> (ø)
...omponents/StepEditForm/fields/CheckboxRowField.tsx 77.77% <0.00%> (-9.73%) ⬇️
...onents/StepEditForm/forms/MoveLiquidForm/index.tsx 0.00% <0.00%> (ø)
...ocol-designer/src/components/StepEditForm/utils.ts 34.92% <0.00%> (-1.75%) ⬇️
... and 9 more

... and 42 files with indirect coverage changes

@jerader jerader changed the title Pd bug fixes 7.0 fix(Protocol-designer): labware, gripper, truncated text mods Jul 27, 2023
@jerader jerader changed the title fix(Protocol-designer): labware, gripper, truncated text mods fix(protocol-designer, components): labware, gripper, truncated text mods Jul 27, 2023
@@ -111,7 +112,7 @@ export const duplicateLabware: (
payload: {
duplicateLabwareNickname,
templateLabwareId,
duplicateLabwareId: uuid(),
duplicateLabwareId: uuid() + ':' + templateLabwareDefURI,
Copy link
Collaborator Author

@jerader jerader Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't necessarily fix anything here but it is needed for multi tiprack support. This change also makes duplicate labware ids match the correct shape of a uuid + defURI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe using Template literals instead of +?

Suggested change
duplicateLabwareId: uuid() + ':' + templateLabwareDefURI,
duplicateLabwareId: `${uuid()}:${templateLabwareDefURI}`,

@jerader jerader marked this pull request as ready for review July 28, 2023 22:14
@jerader jerader requested a review from a team as a code owner July 28, 2023 22:14
@jerader jerader requested review from koji and a team and removed request for a team July 28, 2023 22:14
@jerader jerader changed the title fix(protocol-designer, components): labware, gripper, truncated text mods fix(protocol-designer, components): 7.0 candidate a bug fixes Jul 28, 2023
@koji
Copy link
Contributor

koji commented Jul 31, 2023

Screenshot 2023-07-31 at 12 19 56 PM
In sidebar, description/notes would be needed to truncate the text

@koji
Copy link
Contributor

koji commented Jul 31, 2023

Screenshot 2023-07-31 at 12 30 02 PM
STARTING DECK STATE is supposed to display like☝️ when a protocol name is long?

@jerader
Copy link
Collaborator Author

jerader commented Jul 31, 2023

Screenshot 2023-07-31 at 12 30 02 PM STARTING DECK STATE is supposed to display like☝️ when a protocol name is long?

@koji, good catch! i think this is okay as is. the bug was that the Starting deck state text would get truncated. The protocol name is truncated using css's --truncate so i don't think there's much room for customization.

@jerader jerader requested review from koji and a team July 31, 2023 18:48
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good to me

@jerader jerader merged commit 5a6cb40 into edge Aug 1, 2023
49 of 51 checks passed
@jerader jerader deleted the pd_bug-fixes-7.0 branch August 1, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants