-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(protocol-designer, components): 7.0 candidate a bug fixes #13179
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #13179 +/- ##
==========================================
- Coverage 72.56% 72.23% -0.34%
==========================================
Files 2393 2357 -36
Lines 66055 64000 -2055
Branches 7348 7370 +22
==========================================
- Hits 47935 46229 -1706
+ Misses 16360 16006 -354
- Partials 1760 1765 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -111,7 +112,7 @@ export const duplicateLabware: ( | |||
payload: { | |||
duplicateLabwareNickname, | |||
templateLabwareId, | |||
duplicateLabwareId: uuid(), | |||
duplicateLabwareId: uuid() + ':' + templateLabwareDefURI, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't necessarily fix anything here but it is needed for multi tiprack support. This change also makes duplicate labware ids match the correct shape of a uuid + defURI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe using Template literals instead of +
?
duplicateLabwareId: uuid() + ':' + templateLabwareDefURI, | |
duplicateLabwareId: `${uuid()}:${templateLabwareDefURI}`, |
@koji, good catch! i think this is okay as is. the bug was that the |
protocol-designer/src/components/LabwareSelectionModal/LabwareSelectionModal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes look good to me
bf4d4a7
to
f4b6ab4
Compare
closes RQA-1080, RQA-1125, RQA-1102, RQA-1109, RAUT-589, RAUT-590, RQA-1110, RQA-1122, RQA-1100, RQA-1141, RQA-1148, RQA-1151
Overview
Addresses a handful of bugs
Test Plan
sandbox: https://sandbox.designer.opentrons.com/pd_bug-fixes-7.0/
On the sandbox build, test that each bug got addressed;
beta
tag. See Linda's comment in RQA-1100touch_tip
option should be disabled in advanced settings in the transfer step when you try to touch tip with a labware that doesn't support it. Hovering over it should show a tooltip explaining why its disabled (RQA-1148)moveLabware
step in the timeline should have the correct information shown (should display labware, new location, and if gripper is used or manual intervention is required) RQA-1151Changelog
protocol-designer
directory - adding truncated strings, labware to recommended labware list, fixing a url, duplicate labware bugReview requests
see test plan
Risk assessment
low